[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence added a comment. In D111866#3111243 , @asb wrote: > LGTM, modulo one tiny nit on a comment. Thanks! Thank you for your detailed suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D111866: [RISCV] Support Zfhmin extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c3d7184b435: [RISCV] Support Zfhmin extension (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 385121. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM, modulo one tiny nit on a comment. Thanks! Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZfh.td:253 def PseudoFSH : PseudoStore<"fsh", FPR16>; } // Predicates =

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 384729. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 384337. achieveartificialintelligence added a comment. Address @asb 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb added inline comments. Herald added a subscriber: luke957. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1153 bool ForCodeSize) const { - if (VT == MVT::f16 && !Subtarget.hasStdExtZfh()) + if (VT == MVT::f16 &&

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 383040. achieveartificialintelligence added a comment. Address @asb 's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D111866: [RISCV] Support Zfhmin extension

asb added a comment. Herald added a reviewer: luke957. From an initial look, I think this is almost ready to land - thank you. One suggestion would be to review the various `Subtarget.hasStdExtZfhmin() || Subtarget.hasStdExtZfh()`. I'd first thought adding a new helper to RISCVSubtarget to be

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 382195. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence added a comment. Is there any suggestion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 ___ cfe-commits mailing list

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 380323. achieveartificialintelligence added a comment. Herald added a subscriber: jdoerfert. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence updated this revision to Diff 379924. achieveartificialintelligence added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files:

[PATCH] D111866: [RISCV] Support Zfhmin extension

achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, jrtc27, kito-cheng, asb, luismarques. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,