[PATCH] D112001: [Clang] Add min/max reduction builtins.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7999355106fb: [Clang] Add min/max reduction builtins. (authored by fhahn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D112001: [Clang] Add min/max reduction builtins.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 383900. fhahn added a comment. In D112001#3099965 , @aaron.ballman wrote: > Precommit CI looks to be failing. > > > /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/builtins-reduction-math.c:13:9: >

[PATCH] D112001: [Clang] Add min/max reduction builtins.

aaron.ballman added a comment. Precommit CI looks to be failing. /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/builtins-reduction-math.c:13:9: error: initializing 'float' with an expression of incompatible type 'float4' (vector of 4 'float' values) float r1 = __built

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 383756. fhahn added a comment. rebase on top of recent changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files: clang/include/clang/Basic/Builtins.def clang/

[PATCH] D112001: [Clang] Add min/max reduction builtins.

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16606-16609 + const VectorType *VecTy = TyA->getAs(); + if (!VecTy) +return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) + << "vector" << TyA; --

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 382240. fhahn added a comment. Rebased after recent changes in D111985 https://reviews.llvm.org/D111985: changes the return type of SemaBuiltinReduceMath to bool and drop the CallResult argument. Also added tests with const

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 380948. fhahn marked an inline comment as done. fhahn added a comment. rebase on top of recently updated patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files:

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn marked an inline comment as done. fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16673 + if (!VecTy) + if (!TyA->getAs()) + return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) craig.topper wrote: >

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn updated this revision to Diff 380486. fhahn added a comment. Remove stray `!TyA->getAs()` check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112001/new/ https://reviews.llvm.org/D112001 Files: clang/include/clang/Basic/Builtins.def cla

[PATCH] D112001: [Clang] Add min/max reduction builtins.

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16673 + if (!VecTy) + if (!TyA->getAs()) + return Diag(A->getBeginLoc(), diag::err_elementwise_math_invalid_arg_type_2) Is this indented incorrectly? There appear to be 2 ifs

[PATCH] D112001: [Clang] Add min/max reduction builtins.

fhahn created this revision. fhahn added reviewers: aaron.ballman, scanon, craig.topper, rjmccall, erichkeane. fhahn requested review of this revision. Herald added a project: clang. This patch implements __builtin_reduce_max and __builtin_reduce_min as specified in D111529