[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

aaron.ballman added a comment. In D112101#3097618 , @rsmith wrote: > In D112101#3097387 , @rsmith wrote: > >> I think this is still not quite right > > Fixed in rG68ffcd521347e3c8b97ca233239d503beff239f4 >

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

rsmith added a comment. In D112101#3097387 , @rsmith wrote: > I think this is still not quite right Fixed in rG68ffcd521347e3c8b97ca233239d503beff239f4 . Repository: rG LLVM

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

rsmith added a comment. I think this is still not quite right: if the `ObjCObjectPointerType` has a valid star location, we should use that. We should only be falling back on the inner location's end when there is no star. For example: @interface X @end; using ObjectPointer = X*; ...

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit on your behalf in a9db0a804a5335b6534995c54ab9d6fcef06e739 , thank you for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need someone to commit on your behalf? If so, let me know what name and email address you would like me to use for patch attribution and I can land it after giving

[PATCH] D112101: [AST] Fix the EndLoc calculation for ObjCObjectPointer

lpetre created this revision. lpetre updated this revision to Diff 381958. lpetre added a comment. lpetre updated this revision to Diff 381960. lpetre retitled this revision from "Fix the EndLoc calculation for ObjCObjectPointer" to "[AST] Fix the EndLoc calculation for ObjCObjectPointer". lpetre