[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2b7aabb57d5: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude. (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

khchen added a comment. LGTM, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

rogfer01 added a comment. Looks good to me too. Thanks a lot @craig.topper ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added a comment. It looks good to me. Wait for others' opinions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 ___ cfe-commits mailing list

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added a comment. In D112102#3075400 , @craig.topper wrote: > In D112102#3074656 , @frasercrmck > wrote: > >> Minor typo in the description: `differnet` >> >> Does this help with compile times, binary

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

craig.topper updated this revision to Diff 380982. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

craig.topper added a comment. In D112102#3074656 , @frasercrmck wrote: > Minor typo in the description: `differnet` > > Does this help with compile times, binary sizes, etc? This reduces the clang binary size by 2.34 megabytes according to my local

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added a comment. In D112102#3074656 , @frasercrmck wrote: > Minor typo in the description: `differnet` > > Does this help with compile times, binary sizes, etc? After this patch, we may be able to consider removing all type ending C APIs.

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmerge-rv32.ll:1358 +; CHECK-NEXT:vsetvli zero, a0, e16, mf4, ta, mu +; CHECK-NEXT:vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT:ret frasercrmck wrote: > HsiangKai wrote: > >

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

khchen added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:120 // type transformer (say "vv") each of the types is separated with an // underscore as in "__builtin_rvv_foo_i32m1_i32m1". // nit: we need to update this comment.

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

frasercrmck added a comment. Minor typo in the description: `differnet` Does this help with compile times, binary sizes, etc? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112102/new/ https://reviews.llvm.org/D112102

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

frasercrmck added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmerge-rv32.ll:1358 +; CHECK-NEXT:vsetvli zero, a0, e16, mf4, ta, mu +; CHECK-NEXT:vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT:ret HsiangKai wrote: > vmerge.vvm is for integer

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

HsiangKai added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vmerge-rv32.ll:1358 +; CHECK-NEXT:vsetvli zero, a0, e16, mf4, ta, mu +; CHECK-NEXT:vmerge.vvm v8, v8, v9, v0 +; CHECK-NEXT:ret vmerge.vvm is for integer vectors, doesn't it? Why

[PATCH] D112102: [RISCV] Reduce the number of RISCV vector builtins by an order of magnitude.

craig.topper created this revision. craig.topper added reviewers: khchen, kito-cheng, arcbbb, HsiangKai, evandro, MaskRay, aeubanks, nikic. Herald added subscribers: achieveartificialintelligence, StephenFan, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl,