This revision was automatically updated to reflect the committed changes.
NeHuang marked 5 inline comments as done.
Closed by commit rG18fe0a0d9eb1: [PowerPC] PPC backend optimization to lower
int_ppc_tdw/int_ppc_tw intrinsics… (authored by NeHuang).
Changed prior to commit:
amyk accepted this revision.
amyk added a comment.
Aside from Nemanja's comments, this patch LGTM. Thanks for addressing the
comments!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112285/new/
https://reviews.llvm.org/D112285
nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.
LGTM other than a number of stylistic changes. Feel free to address those on
the commit. You also might want to give @amyk a bit of time to ensure her
comments were adequately addressed.
NeHuang updated this revision to Diff 384768.
NeHuang marked 3 inline comments as done.
NeHuang added a comment.
Address review comments from @nemanjai
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112285/new/
https://reviews.llvm.org/D112285
NeHuang updated this revision to Diff 384479.
NeHuang marked 5 inline comments as done.
NeHuang added a comment.
Addressed review comments from @amy
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112285/new/
https://reviews.llvm.org/D112285
Files:
nemanjai requested changes to this revision.
nemanjai added inline comments.
This revision now requires changes to proceed.
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001
+ case ISD::INTRINSIC_VOID: {
+if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw ||
+
NeHuang added inline comments.
Comment at:
llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131
+; CHECK: # %bb.0:
+; CHECK-NEXT:tdi 3, 3, 32767
+; CHECK-NEXT:blr
amyk wrote:
> amyk wrote:
> > nemanjai wrote:
> > > Can we add
amyk added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5001
+ case ISD::INTRINSIC_VOID: {
+if (N->getConstantOperandVal(1) == Intrinsic::ppc_tdw ||
+N->getConstantOperandVal(1) == Intrinsic::ppc_tw) {
Might be a good
NeHuang updated this revision to Diff 383506.
NeHuang added a comment.
Addressed review comments from @nemanjai and @amyk
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112285/new/
https://reviews.llvm.org/D112285
Files:
amyk added inline comments.
Comment at:
llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:131
+; CHECK: # %bb.0:
+; CHECK-NEXT:tdi 3, 3, 32767
+; CHECK-NEXT:blr
nemanjai wrote:
> Can we add `-ppc-asm-full-reg-names` to the RUN
nemanjai added inline comments.
Comment at: llvm/lib/Target/PowerPC/PPCISelDAGToDAG.cpp:5003
+N->getConstantOperandVal(1) == Intrinsic::ppc_tw) {
+ int16_t SImm;
+ if (isIntS16Immediate(N->getOperand(3), SImm)) {
I think a couple of
NeHuang created this revision.
NeHuang added reviewers: nemanjai, stefanp, PowerPC.
NeHuang added a project: LLVM.
Herald added subscribers: shchenz, kbarton, hiraditya.
NeHuang requested review of this revision.
This patch adds the backend optimization to match XL behavior for the two
builtins
12 matches
Mail list logo