[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. In D112356#3082218 , @Quuxplusone wrote: > Definitely an improvement! I looked at all the changed places and found some > more improvements you can make. I don't need to see this again, though. Thanks for the

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added a comment. Definitely an improvement! I looked at all the changed places and found some more improvements you can make. I don't need to see this again, though. The only disimprovement I found was "Jaro–Winkler" becoming "Jaro-Winkler". Comment at:

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. In D112356#3082084 , @carlosgalvezp wrote: > Awesome @salman-javed-nz , thanks for fixing the docs! May I ask how did you > create these "smaller commits"? It's very nice to click on each of them and > see only what

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Awesome @salman-javed-nz , thanks for fixing the docs! May I ask how did you create these "smaller commits"? It's very nice to click on each of them and see only what changed. I believe I followed your same procedure (use the "Update Revision" thingy) but it

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Kazu Hirata via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5de69e16ea9a: [clang-tidy] Tidy up spelling, grammar, and inconsistencies in documentation… (authored by salman-javed-nz, committed by kazu).

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. Thanks for the review. Are you able to commit for me? Salman Javed Thank you very much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-23 Thread Kazu Hirata via Phabricator via cfe-commits
kazu accepted this revision. kazu added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing the docs! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381710. salman-javed-nz added a comment. Pre-merge checks failing because patch cannot be applied. Therefore recreating patch to fix this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz added a comment. A collection of minor corrections that I don't think deserve separate commits. It shouldn't take much congitive load to remove it all as one patch. But I have used Phabricator's "Update Revision" feature to break out the change into smaller chunks anyway.

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381707. salman-javed-nz added a comment. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Fix spelling and grammatical mistakes found across the .rst files. // end of patch Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381706. salman-javed-nz added a comment. Standardize to US English spelling for words such as "behavior" and "specialization". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381704. salman-javed-nz added a comment. Herald added a reviewer: lebedev.ri. Herald added a subscriber: lebedev.ri. Remove repeated words, e.g. "for a a larger user input". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381703. salman-javed-nz added a comment. Standardize spelling of "e.g." and "i.e." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/ https://reviews.llvm.org/D112356 Files:

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381702. salman-javed-nz added a comment. Herald added subscribers: kbarton, nemanjai. Replace curly quote characters (‘ ’ “ ”) with standard straight ones (' "). Replace en-dash (`–`) with standard hyphen (`-`). In both cases, the latter is used more

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz updated this revision to Diff 381701. salman-javed-nz added a comment. Herald added a subscriber: arphaman. Change double spaces after commas and periods to single space. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112356/new/

[PATCH] D112356: [NFC] Tidy up spelling, grammar, and inconsistencies in clang-tidy documentation

2021-10-22 Thread Salman Javed via Phabricator via cfe-commits
salman-javed-nz created this revision. salman-javed-nz added reviewers: aaron.ballman, whisperity, kazu. salman-javed-nz added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs. salman-javed-nz requested review of this revision. - Fix spelling and grammatical