[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman closed this revision. aaron.ballman added a comment. Thanks, I've commit in a1879e52e3ae9424b59747d9b837a7a87bcb996d Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

rjmccall added a comment. Okay. I guess the only choice, then, would be to not try to parse a template deduction guide when you're in a context where template deduction guides aren't allowed. Maybe that's not actually reasonable. Well, whatever. I don't really have a problem with this patch;

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

erichkeane added a comment. In D112616#3177261 , @rjmccall wrote: > The only alternative to this that I can see would be for the invalid code to > produce more valid-seeming AST. > > Are deduction guides just not normally allowed for methods? > > Also, w

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

rjmccall added a comment. The only alternative to this that I can see would be for the invalid code to produce more valid-seeming AST. Are deduction guides just not normally allowed for methods? Also, while I don't think it would eliminate the need to be defensive here, our recovery from misna

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I'm about as confident as _I_ could be on this one, so between that and the time, I think my LGTM now carries a bit of weight. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman added a comment. In D112616#3106436 , @aaron.ballman wrote: > Ping Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112616/new/ https://reviews.llvm.org/D112616 _

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112616/new/ https://reviews.llvm.org/D112616 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D112616: Fix crash on invalid code involving late parsed inline methods

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, erichkeane, rjmccall, arthur.j.odwyer. aaron.ballman requested review of this revision. Herald added a project: clang. When parsing the following construct, we parse it as an erroneous deduction guide declaration and corr