This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4860f6cb25bd: [OpenMP] Fix: opposite attributes could be set
by -fno-inline (authored by igor.kirillov).
Repository:
rG LLVM Github Monorepo
igor.kirillov updated this revision to Diff 383892.
igor.kirillov added a comment.
Remove my old test for the change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112645/new/
https://reviews.llvm.org/D112645
Files:
igor.kirillov updated this revision to Diff 383890.
igor.kirillov marked an inline comment as not done.
igor.kirillov added a comment.
Update test, remove redundant code
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112645/new/
jhuber6 added inline comments.
Comment at: clang/test/OpenMP/parallel_for_noinline.cpp:1
+// RUN: %clang -O0 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-O0
+// RUN: %clang -O1 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s
igor.kirillov added inline comments.
Comment at: clang/test/OpenMP/parallel_for_noinline.cpp:1
+// RUN: %clang -O0 -fopenmp -fno-inline %s -S -emit-llvm -o - | FileCheck %s
--check-prefixes=CHECK,CHECK-O0
+// RUN: %clang -O1 -fopenmp -fno-inline %s -S -emit-llvm -o - |
jhuber6 accepted this revision.
jhuber6 added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5370
if (CGM.getCodeGenOpts().OptimizationLevel != 0)
Fn->addFnAttr(llvm::Attribute::AlwaysInline);
return
igor.kirillov added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:5370
if (CGM.getCodeGenOpts().OptimizationLevel != 0)
Fn->addFnAttr(llvm::Attribute::AlwaysInline);
return Fn;
I noticed that here we set this attribute on the same
igor.kirillov created this revision.
Herald added subscribers: guansong, yaxunl.
igor.kirillov requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.
After the changes introduced by D106799
