[PATCH] D112661: [clangd] reuse preambles from other files when possible

2022-06-08 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau added a comment. @nridge after rebasing this change for several months, I find it less and less useful. It seems both clangd and the IDE I'm using are making significant improvements that make this changes less and less impactful. I closed this revision as I feel that it now passed the

[PATCH] D112661: [clangd] reuse preambles from other files when possible

2022-06-06 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. @qchateau How should I interpret the abandoning of this patch -- did you run into a problem with the approach, or just don't have the time / interest to pursue it further? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11266

[PATCH] D112661: [clangd] reuse preambles from other files when possible

2022-05-14 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau updated this revision to Diff 429478. qchateau added a comment. Small correction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112661/new/ https://reviews.llvm.org/D112661 Files: clang-tools-extra/clangd/ClangdServer.cpp clang-tools-e

[PATCH] D112661: [clangd] reuse preambles from other files when possible

2022-05-14 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau updated this revision to Diff 429470. qchateau added a comment. Herald added a project: All. Resolve conflicts, fix formatting, simplify patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112661/new/ https://reviews.llvm.org/D112661 File

[PATCH] D112661: [clangd] reuse preambles from other files when possible

2021-10-27 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau added a comment. This is a revisit of D97417 which is a bit out of date and fell into oblivion. I've been using a forked version of clangd including this change for months on my day-to-day work and it does significantly improve my experience. Some numbe

[PATCH] D112661: [clangd] reuse preambles from other files when possible

2021-10-27 Thread Quentin Chateau via Phabricator via cfe-commits
qchateau created this revision. qchateau added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman, javed.absar. qchateau requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Keep a s