[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9c8bab0c7a: [RISCV] Support k-ext clang intrinsics (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 ___

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 412698. achieveartificialintelligence marked 7 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added inline comments. Herald added a project: All. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:75 +// Zbkb extension +TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb") +TARGET_BUILTIN(__builtin_riscv_zip, "ZiZi", "nc", "zbkb")

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 411676. achieveartificialintelligence added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Bas

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 411675. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks for @craig.topper's detailed advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added a comment. Any intrinsic that takes an immediate that needs to be in certain range, needs to have code added to SemaChecking.cpp to validate the range. Look for the other places we call SemaBuiltinConstantArgRange in Sema::CheckRISCVBuiltinFunctionCall Com

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 411379. achieveartificialintelligence added a comment. Ping & Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clan

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 410444. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Basic

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 408319. achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:80 +// Zknd extension +TARGET_BUILTIN(__builtin_riscv_aes32dsi, "ZiZiZiUc", "nc", "zknd") +TARGET_BUILTIN(__builtin_riscv_aes32dsmi, "ZiZiZiUc", "nc", "zknd") Uc -> IUc T

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 408310. achieveartificialintelligence added a comment. Ping & Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/cla

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 405997. achieveartificialintelligence added a comment. Amend tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 405989. achieveartificialintelligence marked 3 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:74 +// zbkb extension +TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb") Capital Z Comment at: clang/lib/Basic/Targets/RISCV.cpp:198 +

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

achieveartificialintelligence updated this revision to Diff 405605. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Basic