This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG1b758925adf6: [IR] Merge createReplacementInstr into
ConstantExpr::getAsInstruction (authored by foad).
Repository:
rG LLVM Github Monorepo
foad added inline comments.
Comment at: llvm/include/llvm/IR/Constants.h:1317
/// would make it harder to remove ConstantExprs altogether.
- Instruction *getAsInstruction() const;
+ Instruction *getAsInstruction(Instruction *InsertBefore = nullptr) const;
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112791/new/
https://reviews.llvm.org/D112791
___
cfe-commits mailing list
foad updated this revision to Diff 383341.
foad added a comment.
Add comment about InsertBefore.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112791/new/
https://reviews.llvm.org/D112791
Files:
clang/lib/CodeGen/CGCUDANV.cpp
yaxunl added inline comments.
Comment at: llvm/include/llvm/IR/Constants.h:1317
/// would make it harder to remove ConstantExprs altogether.
- Instruction *getAsInstruction() const;
+ Instruction *getAsInstruction(Instruction *InsertBefore = nullptr) const;
hsmhsm accepted this revision.
hsmhsm added a comment.
This revision is now accepted and ready to land.
Thanks for this clean-up patch. Looks good to me. However, please wait for some
time if in case other reviewers have any comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
foad created this revision.
Herald added subscribers: ormris, dexonsmith, hiraditya.
foad requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
createReplacementInstr was a trivial wrapper around
ConstantExpr::getAsInstruction,
