This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3a3af2bbc97e: [C++20] [Module] fix bug 47716 and implement
[module.interface]/p6 (authored by ChuanqiXu).
Repository:
rG LLVM Github Monorepo
CHA
urnathan accepted this revision.
urnathan added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for working on this
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
___
cfe-co
ChuanqiXu added a comment.
@aaron.ballman @urnathan gentle ping~
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
ChuanqiXu added a comment.
@aaron.ballman @urnathan gentle ping~
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
ChuanqiXu added a comment.
@aaron.ballman @urnathan gentle ping~
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
ChuanqiXu marked 5 inline comments as done.
ChuanqiXu added inline comments.
Comment at: clang/lib/Sema/SemaDecl.cpp:1622
+// [module.interface]p6:
+// A redeclaration of an entity X is implicitly exported if X was introduced by
aaron.ballman wrote:
>
I didn't
ChuanqiXu updated this revision to Diff 395045.
ChuanqiXu added a comment.
Address comments
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
Files:
clang/include/clang/AST/DeclBase.h
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/
aaron.ballman added inline comments.
Comment at: clang/include/clang/AST/DeclBase.h:616
+ bool isInExportDeclContext() const;
+
I think it would be good to add some comments to document the function (as done
with surrounding code).
Comment
ChuanqiXu added a comment.
@rsmith @aaron.ballman @urnathan gentle ping~
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org
ChuanqiXu updated this revision to Diff 393030.
ChuanqiXu added a comment.
Rebased
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
Files:
clang/include/clang/AST/DeclBase.h
clang/include/clang/Basic/DiagnosticSemaKinds.td
clang/include/c
ChuanqiXu added a comment.
@aaron.ballman @urnathan gentle ping~
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
ChuanqiXu updated this revision to Diff 387144.
ChuanqiXu added a comment.
Fix a mismatch in test
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112903/new/
https://reviews.llvm.org/D112903
Files:
clang/include/clang/AST/DeclBase.h
clang/include/clang/Basic/DiagnosticSemaKinds.td
12 matches
Mail list logo