[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfbf52caf58b3: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support (authored by Jake-Egan). Repository: rG LLVM Github

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the explanation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Jake-Egan wrote: > > > shchenz wrote: > >

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Jake-Egan wrote: > > shchenz wrote: > > > Do we still need

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. Look almost good! Thanks for doing this. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Do we

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c shchenz wrote: > Do we still need

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395904. Jake-Egan added a comment. Fixed typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files: clang/test/ASTMerge/codegen-body/test.c

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ASTMerge/anonymous-fields/test.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/anonymous-fields1.cpp Do we still need this? `-emit-obj` is already excluded?

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan marked an inline comment as done. Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir shchenz wrote: > Jake-Egan wrote: > > jsji wrote: > > >

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 395724. Jake-Egan added a comment. Added `-fintegrated-as` option. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir Jake-Egan wrote: > jsji wrote: > > there is no `fmodule-format=obj` here, why are we failing here? > > >

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389849. Jake-Egan added a comment. Removed some tests already disabled by D114481 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added inline comments. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir jsji wrote: > there is no `fmodule-format=obj` here, why are we failing here? > They have the same

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Thanks, looks much better now. Comment at: clang/test/ClangScanDeps/modules-full-by-mod-name.cpp:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: rm -rf %t.dir there is no `fmodule-format=obj` here, why are we failing here?

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 389196. Jake-Egan added a comment. Thanks for the review. I updated the patch to use lit.cfg.py to filter tests that use obj options. For tests that don't use the option or has an individual folder, I changed them to UNSUPPORTED instead of XFAIL.

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140174 , @lkail wrote: > Is there any way to filter these tests out on AIX in `lit.local.cfg`? Agree, I would prefer we do something similar to

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. In D113049#3140165 , @Jake-Egan wrote: > In D113049#3140160 , @jsji wrote: > >> Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? > > If 64-bit XCOFF object files will be

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

lkail added a comment. Is there any way to filter these tests out on AIX in `lit.local.cfg`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan added a comment. In D113049#3140160 , @jsji wrote: > Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? If 64-bit XCOFF object files will be supported in the future, I think it makes more sense to use `XFAIL` because these

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

jsji added a comment. Can we use `UNSUPPORTED` instead of `XFAIL` since it is unsupported? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 ___ cfe-commits

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 385830. Jake-Egan added a comment. Add `LLVM :: DebugInfo/attr-btf_type_tag.ll` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384521. Jake-Egan added a comment. Updated patch to XFAIL only on 64-bit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. This seems not right. Now we disable too many debug cases for object mode even for 32bit target. Maybe we should test clang (built with `--default-target-triple=powerpc64-ibm-aix`) after our backend support 64-bit object mode(`-filetype=obj`) Repository: rG LLVM

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan updated this revision to Diff 384220. Jake-Egan added a comment. Fix llvm/test/DebugInfo/omit-empty.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113049/new/ https://reviews.llvm.org/D113049 Files:

[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

Jake-Egan created this revision. Herald added subscribers: ormris, lxfind, pengfei, arphaman, steven_wu, hiraditya. Jake-Egan requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo