[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

This revision was automatically updated to reflect the committed changes. Szelethus marked 2 inline comments as done. Closed by commit rG29a8d45c5a23: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators (authored by Szelethus). Changed prior to commit: https://reviews

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

whisperity added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp:155-167 +/// Look through conversion/copy constructors and operators to find the explicit /// initialization expression, returning it is found. /// /// The main idea is t

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM modulo comments from @steakhal! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 ___ cf

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Eugene.Zelenko added a comment. Please wait for @aaron.ballman approval. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Szelethus added a reviewer: Eugene.Zelenko. Szelethus added a comment. I'll intend to land this by friday unless there are objections! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://reviews.llvm.org/D113201 ___ cfe-commits

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Looks great. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp:155 -/// Look through conversion/copy constructors to find the explicit +/// Look t

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Szelethus updated this revision to Diff 385459. Szelethus edited the summary of this revision. Szelethus added a comment. Clarify the summary. Delete unnecessary includes. More fitting `iterator` names in the test files. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113201/new/ https://

[PATCH] D113201: [clang-tidy] Fix a crash in modernize-loop-convert around conversion operators

Szelethus created this revision. Szelethus added reviewers: aaron.ballman, alexfh, steakhal, whisperity. Szelethus added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, martong, gamesh411, dkrupp, rnkovacs, xazax.hun. Szelethus requested review of this revision. Herald added