[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-12-12 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/CMakeLists.txt:230 +option(CLANG_DEFAULT_PIE "Default to -fPIE and -pie (Linux only)" OFF) +if(CLANG_DEFAULT_PIE) joerg wrote: > This option should really be called something like CLANG_DEFAULT_PIE_ON_LINUX >

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-12-11 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg added inline comments. Comment at: clang/CMakeLists.txt:230 +option(CLANG_DEFAULT_PIE "Default to -fPIE and -pie (Linux only)" OFF) +if(CLANG_DEFAULT_PIE) This option should really be called something like CLANG_DEFAULT_PIE_ON_LINUX or so. It should be

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-12-11 Thread Evangelos Foutras via Phabricator via cfe-commits
foutrelis accepted this revision. foutrelis added a comment. No issues with default PIE and SSP on Arch for over 4 years now. It's nice to see this being upstreamed; thanks for doing it. This patch worked fine. Based on my own hack

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-12-01 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a subscriber: felixonmars. MaskRay added a comment. I will wait until Dec 14 before committing. Hope Arch Linux folks can test this, too: @felixonmars @foutrelis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-12-01 Thread Sam James via Phabricator via cfe-commits
thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. This is working well here on Gentoo. This brings some long-desired feature parity to Clang which we've been wanting downstream: GCC has had this option for quite a few years (after

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-11-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 389305. MaskRay added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Add a release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-11-23 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. Maybe add it to the release notes too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-11-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-11-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 385375. MaskRay added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie

2021-11-07 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: foutrelis, manojgupta, sylvestre.ledru, thesamesam, tstellar. Herald added a subscriber: mgorny. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 2015-05, GCC added the