[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay added a comment. In D113372#3316751 , @mgorny wrote: > When enabled, this seems to break a fair number of tests: > > Clang :: CodeGen/mips-vector-return.c > Clang :: Driver/hexagon-toolchain-elf.c > Clang :: Driver/hip-fpie-option.hip >

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

mgorny added a comment. When enabled, this seems to break a fair number of tests: Clang :: CodeGen/mips-vector-return.c Clang :: Driver/hexagon-toolchain-elf.c Clang :: Driver/hip-fpie-option.hip Clang :: Driver/mips-cs.cpp Clang :: Driver/mips-fsf.cpp Clang :: Driver/mips-img-v2.cpp

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay marked an inline comment as done. MaskRay added inline comments. Comment at: clang/CMakeLists.txt:232 +if(CLANG_DEFAULT_PIE_ON_LINUX) + set(CLANG_DEFAULT_PIE_ON_LINUX 1) +endif() arichardson wrote: > Can these 3 lines be removed after D115751? Thx.

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

arichardson added inline comments. Comment at: clang/CMakeLists.txt:232 +if(CLANG_DEFAULT_PIE_ON_LINUX) + set(CLANG_DEFAULT_PIE_ON_LINUX 1) +endif() Can these 3 lines be removed after D115751? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1042de90589c: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie (authored by MaskRay). Changed prior to commit:

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 394015. MaskRay added a comment. Rename test/Driver/default-pie.c to linux-default-pie.c clang-format a region. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay added a comment. In D113372#3188178 , @joerg wrote: > Last update introduced a lot of unrelated changes? But the actual intended > change seems fine now. The last update just did a renaming. I have checked that changes are all intended.

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

joerg added a comment. Last update introduced a lot of unrelated changes? But the actual intended change seems fine now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113372/new/ https://reviews.llvm.org/D113372

[PATCH] D113372: [Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie

MaskRay updated this revision to Diff 393782. MaskRay retitled this revision from "[Driver] Add CLANG_DEFAULT_PIE to emulate GCC --enable-default-pie" to "[Driver] Add CLANG_DEFAULT_PIE_ON_LINUX to emulate GCC --enable-default-pie". MaskRay edited the summary of this revision. MaskRay added a