salman-javed-nz added a comment.
@aaron.ballman -
I've added the unit test for UNC path as you suggested. Since you've already
given the LGTM, I assume you don't need to see the patch again, so I have gone
ahead with the commit.
Anyway, I'll be around to address any problems if they crop up.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb4f6f1c9369e: [clang-tidy] Fix llvm-header-guard so that it
works with Windows paths (authored by salman-javed-nz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
salman-javed-nz updated this revision to Diff 385780.
salman-javed-nz added a comment.
Unit tests:
- Renamed Samba to SMB
- Added test for UNC paths
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113450/new/
https://reviews.llvm.org/D113450
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thank you for the fix!
Comment at: clang-tools-extra/unittests/clang-tidy/LLVMModuleTest.cpp:248-250
+ runHeaderGuardCheck(
+ "",
salman-javed-nz created this revision.
salman-javed-nz added reviewers: bkramer, hokein, aaron.ballman.
salman-javed-nz added a project: clang-tools-extra.
Herald added subscribers: carlosgalvezp, xazax.hun.
salman-javed-nz requested review of this revision.
Fixes
