[PATCH] D113491: [HIP] Fix device stub name for Windows

2021-11-23 Thread Yaxun Liu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG38211bbab1d9: [HIP] Fix device stub name for Windows (authored by yaxunl). Herald added a project: clang. C

[PATCH] D113491: [HIP] Fix device stub name for Windows

2021-11-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/lib/AST/MicrosoftMangle.cpp:975-976 + llvm::SmallString<128> Buf; + mangleSourceName((llvm::Twine("__device_stub__") + II->getName()) + .toStri

[PATCH] D113491: [HIP] Fix device stub name for Windows

2021-11-09 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM in general. Comment at: clang/lib/AST/MicrosoftMangle.cpp:975-976 + llvm::SmallString<128> Buf; + mangleSourceName((llvm::Twine("__device_stub__") + II->getN

[PATCH] D113491: [HIP] Fix device stub name for Windows

2021-11-09 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added reviewers: tra, rjmccall. yaxunl requested review of this revision. This is a follow up of https://reviews.llvm.org/D68578 where device stub name is changed for Itanium mangling but not Microsoft mangling. https://reviews.llvm.org/D113491 Files: clan