mehdi_amini added a comment.
This is committed r275115 for the record.
Phabricator will automatically close it if the last line is "Differential
Revision: ..." (You put "Differential review: ..." instead).
http://reviews.llvm.org/D11360
___
mehdi_amini accepted this revision.
mehdi_amini added a reviewer: mehdi_amini.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D11360
___
cfe-commits mailing list
wolfgangp added inline comments.
Comment at: test/CodeGen/forwarding-blocks-if.c:17
@@ +16,3 @@
+return 0;
+}
+
mehdi_amini wrote:
> Any reason to not stick with LLVM coding convention here?
No reason, thanks for pointing this out.
wolfgangp updated this revision to Diff 62916.
wolfgangp added a comment.
Addressed review comments: documented changes and clang-formatted the test case.
http://reviews.llvm.org/D11360
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/forwarding-blocks-if.c
Index:
mehdi_amini added inline comments.
Comment at: lib/CodeGen/CGStmt.cpp:614
@@ -610,1 +613,3 @@
+ SimplifyForwardingBlocks(CurBlock);
+ }
Document
Comment at: lib/CodeGen/CGStmt.cpp:633
@@ -626,1 +632,3 @@
+ if (CurBlock)
+
wolfgangp added a comment.
Ping...
http://reviews.llvm.org/D11360
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wolfgangp updated this revision to Diff 61987.
wolfgangp added a comment.
Herald added a subscriber: mehdi_amini.
Updating this patch against a recent revision.
http://reviews.llvm.org/D11360
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/forwarding-blocks-if.c
Index:
