[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

jyknight added a comment. Should be fixed by rGcaa1ebde70673ddb7124a0599ba846362a1f8b1e . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

jyknight added a comment. Found the problem, tweaking a test-case; will commit shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm.org/D113620 ___ cfe-commits mailing

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

haowei added a comment. Hi, we are seeing clang Windows build breakages after this change was relanded error message: Assertion failed: isa(Val) && "cast() argument of incompatible type!", file C:\b\s\w\ir\x\w\llvm-llvm-project\llvm\include\llvm/Support/Casting.h, line 262 PLEASE submit

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

thakis added a comment. Breaks a few tests on windows too: http://45.33.8.238/win/52616/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/ https://reviews.llvm.org/D113620 ___

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

thakis added a comment. This breaks a bunch of tests on Mac: http://45.33.8.238/macm1/25623/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113620/new/

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

vitalybuka added a comment. Is this from the patch https://lab.llvm.org/buildbot/#/builders/127/builds/22789/steps/8/logs/stdio FAILED: projects/compiler-rt/lib/sanitizer_common/tests/SANITIZER_TEST_OBJECTS.sanitizer_leb128_test.cpp.x86_64.o cmd.exe /C "cd /D

[PATCH] D113620: Skip exception cleanups when the innermost scope is EHTerminateScope.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. I think it's generally better to not run cleanups on the way to a `terminate` call, not only for code size but also for debuggability. This change seems like an improvement to me.