[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c484f11d355: [llvm] Add a SFINAE template parameter to DenseMapInfo (authored by rriddle). Changed prior to commit:

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle updated this revision to Diff 387386. rriddle added a comment. Herald added subscribers: lldb-commits, hiraditya. Herald added a project: LLDB. resolve comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

lattner added a comment. Oh, are you concerned about staging this in? If you want to stage it (add the includes now, remove them later or something), that is totally fine with me. Maybe I don't understand the impact correctly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

lattner added a comment. I think a few void's probably won't hurt anyone? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113641/new/ https://reviews.llvm.org/D113641 ___ cfe-commits mailing list

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle added inline comments. Comment at: llvm/include/llvm/ADT/Hashing.h:59 namespace llvm { -template struct DenseMapInfo; lattner wrote: > Is there a way to keep the forward declarations references here instead of > #include? DenseMapInfo.h pulls in a

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

lattner accepted this revision. lattner added a comment. Herald added a subscriber: sdasgup3. Nice, I'm very excited about this - this will allow a lot of cleanups. Thank you for doing this! Comment at: llvm/include/llvm/ADT/Hashing.h:59 namespace llvm { -template struct

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. Nice :) This looks pretty straightforward, but given how core this is, wait for another approver or two. Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:42 -template

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

bondhugula added inline comments. Comment at: llvm/include/llvm/ADT/DenseMapInfo.h:42 -template -struct DenseMapInfo { +template struct DenseMapInfo { //static inline T getEmptyKey(); A code comment here? Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle added a comment. Given the new template parameter, I needed to update the forward declarations. Some of them already had DenseMapInfo from an include, so I just dropped them. Some didn't, so I opted to just add an include for DenseMapInfo (seemed small enough). I could avoid the

[PATCH] D113641: [llvm] Add a SFINAE template parameter to DenseMapInfo

rriddle created this revision. rriddle added reviewers: dblaikie, mehdi_amini, lattner, silvas. Herald added subscribers: wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, dexonsmith, rdzhabarov, tatianashp, ThomasRaoux, jdoerfert, AlexeySotkin, msifontes, jurahul, Kayjukh, grosul1,