[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

2021-11-11 Thread Craig Topper via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG893efd0d665b: [X86] Honor command line features along with cpu_specific attribute (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

2021-11-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper updated this revision to Diff 386524. craig.topper added a comment. Add test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113647/new/ https://reviews.llvm.org/D113647 Files: clang/lib/AST/ASTContext.cpp clang/test/CodeGen/at

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

2021-11-11 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added a comment. In D113647#3124363 , @erichkeane wrote: > Is there a lit-test that could be added to make sure this happens? We put > this in an llvm-attribute, so it should be checkable. Forgot to git add the file I wrote. Repository:

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

2021-11-11 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Is there a lit-test that could be added to make sure this happens? We put this in an llvm-attribute, so it should be checkable. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D113647: [X86] Honor command line features along with cpu_specific attribute

2021-11-10 Thread Craig Topper via Phabricator via cfe-commits
craig.topper created this revision. craig.topper added reviewers: andrew.w.kaylor, erichkeane, pengfei. craig.topper requested review of this revision. Herald added a project: clang. If the feature is on the command line we should honor it for all functions. I don't think we could reliably target