This revision was automatically updated to reflect the committed changes.
Closed by commit rG625901636134: [clang-tidy] Fix false positive in
readability-identifier-naming check… (authored by fwolff, committed by
salman-javed-nz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
salman-javed-nz accepted this revision.
salman-javed-nz added a comment.
This revision is now accepted and ready to land.
LGTM. Nothing more to suggest from my side. Can we allow a few days for the
other reviewers to put in their 2c.
As for the Bugzilla ticket
fwolff updated this revision to Diff 387401.
fwolff added a comment.
Thanks again for your feedback @salman-javed-nz! I think I've addressed all of
your comments now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113830/new/
https://reviews.llvm.org/D113830
Files:
salman-javed-nz added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:299
// CHECK-FIXES: {{^}} void v_Bad_Base_Method() override {}
+ void BadBaseMethodNoAttr() {}
+ // CHECK-FIXES: {{^}} void
fwolff updated this revision to Diff 387121.
fwolff added a comment.
Thanks for your comments @salman-javed-nz! I have expanded the tests now
according to your suggestions.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113830/new/
https://reviews.llvm.org/D113830
Files:
salman-javed-nz added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:329
+
+ // FIXME: The fixes from ATOverridden should be propagated to the following
call
+ a_vTitem.BadBaseMethod();
The fixes
salman-javed-nz added inline comments.
Comment at:
clang-tools-extra/clang-tidy/readability/IdentifierNamingCheck.cpp:1260
if (Decl->isMain() || !Decl->isUserProvided() ||
-Decl->size_overridden_methods() > 0)
+Decl->size_overridden_methods() > 0 ||
salman-javed-nz added a comment.
Happy to take a look at this, and do some of the initial review legwork, but
let's leave final approval to @aaron.ballman.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113830/new/
https://reviews.llvm.org/D113830
fwolff created this revision.
fwolff added reviewers: alexfh, salman-javed-nz.
fwolff added a project: clang-tools-extra.
Herald added subscribers: carlosgalvezp, xazax.hun.
fwolff requested review of this revision.
Herald added a subscriber: cfe-commits.
Fixes part of PR#45815. Overriding
