[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. In D114115#3477967 , @probinson wrote: > Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` > (or you might factor that bit out into its own test with the REQUIRES). I have moved that test to

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek updated this revision to Diff 426182. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 Files: clang/lib/Driver/ToolChains/Fuchsia.cpp clang/test/Driver/compress.c Index:

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

probinson added a comment. Lit is aware of zlib's presence or absence, you could use `REQUIRES: zlib` (or you might factor that bit out into its own test with the REQUIRES). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

dyung added a comment. I think the problem here is that if zlib is not available, you won't get the clang command line you expect: https://lab.llvm.org/buildbot/#/builders/216/builds/3519 Input was: << 1: clang version 15.0.0 (https://github.com/llvm/llvm-project.git

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

TWeaver added a comment. Hello all, really sorry but I've had to revert this patch due to failures on windows build bots: http://lab.llvm.org:8011/#/builders/216 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG19190cc651ef: [Driver] Support for compressed debug info on Fuchsia (authored by phosek). Herald added a subscriber: MaskRay. Herald added a

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

mcgrathr accepted this revision. mcgrathr added a comment. This revision is now accepted and ready to land. lgtm, but we should be sure to advise users that their debugging tools may need build adjustments to ensure they support the compressed formats. Repository: rG LLVM Github Monorepo

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek added a comment. @mcgrathr Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114115/new/ https://reviews.llvm.org/D114115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D114115: [Driver] Support for compressed debug info on Fuchsia

phosek created this revision. phosek added a reviewer: mcgrathr. Herald added a subscriber: abrachet. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pass the --compress-debug-sections=zlib argument to the linker when the use of