[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

2021-11-30 Thread Di Mo via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9b704d31b54a: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor… (authored by modimo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

2021-11-18 Thread Wenlei He via Phabricator via cfe-commits
wenlei accepted this revision. wenlei added a comment. This revision is now accepted and ready to land. lgtm, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114130/new/ https://reviews.llvm.org/D114130

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

2021-11-18 Thread Di Mo via Phabricator via cfe-commits
modimo updated this revision to Diff 388307. modimo added a comment. Condense lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114130/new/ https://reviews.llvm.org/D114130 Files: clang/include/clang/Driver/Options.td

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

2021-11-17 Thread Wenlei He via Phabricator via cfe-commits
wenlei added inline comments. Comment at: clang/include/clang/Driver/Options.td:5058-5061 + CodeGenOpts<"CXXCtorDtorAliases">, + DefaultFalse, + PosFlag, + NegFlag, nit: use two lines for consistency. check `sanitize_stats`, `sanitize_cfi_cross_dso` and

[PATCH] D114130: [Clang] Add option to disable -mconstructor-aliases with -mno-constructor-aliases

2021-11-17 Thread Di Mo via Phabricator via cfe-commits
modimo created this revision. Herald added subscribers: jeroen.dobbelaere, hoy, wenlei, lxfind, dang. modimo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114130 Files: