[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. As mentioned in my previous comment, here is the RFC proposing a new `annotate_type` attribute: https://discourse.llvm.org/t/rfc-new-attribute-annotate-type-iteration-2/61378 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme abandoned this revision. mboehme added a comment. Herald added a project: All. Thanks for all of the input! Rather than going deeper into the discussion of the attribute here (on an only vaguely related change), I think it would be better to continue the discussion on the forum. I'm

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

erichkeane added a comment. > For my purposes, it would be fine, and maybe even desirable, for the proposed > annotate_type to have the same limitations as _Nonnull. > > Are you saying that a) this would not be acceptable for a more > general-purpose attribute such as a putative annotate_type,

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. In D114235#3340412 , @erichkeane wrote: > In D114235#3340369 , @mboehme wrote: > >> In D114235#3244054 , >> @aaron.ballman wrote: >> >>> so

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

erichkeane added a comment. In D114235#3340369 , @mboehme wrote: > Sorry for the delay -- finally back from leave. > > High-level, I think I'd like to return to my earlier approach >

Re: [PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

Sorry for the incomplete comment -- I pressed "send" too soon. I've edited my comment on Phabricator to add the rest of my reply. (Pointing this out here for people who are reading this in email.) On Wed, 23 Feb 2022 at 15:53, Martin Böhme via Phabricator < revi...@reviews.llvm.org> wrote: >

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Sorry for the delay -- finally back from leave. High-level, I think I'd like to return to my earlier approach of adding a new `annotate_type` attribute (see also discussion above). In

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Aaron and Eric, I'm currently on an extended leave, so I'll only get back to this in a few weeks' time, but I did want to let you know that I've seen this. Thanks for the detailed comments! Cheers, Martin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

erichkeane added a comment. Right, yeah, so there are a couple of problems with AttributedType. First, it gets lost almost as soon as you get out of SemaType about 90% of the time. Anything that does some level of canonicalization ends up losing it, so the AttributedType information is lost

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D114235#3243429 , @mboehme wrote: > Thanks for the feedback! And no worries about the delay -- I know you've got > a lot on your

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Thanks for the feedback! And no worries about the delay -- I know you've got a lot on your plate, and the proposed change is invasive. To make sure I understand correctly: The issue is that if a `Type` is replaced by an `AttributedType` in places where Clang does not

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a comment. First off, thank you so much for your patience while I took the time to think about this. I know it can be frustrating to not hear review feedback in a timely manner, so I'm sorry for that. I've been sitting on this for a while because type attributes are a

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. In D114235#3173745 , @aaron.ballman wrote: > I've not had the chance, sorry! My review queue is rather full at the moment, > so I'm still digging out from under quite a few reviews (around 50 at last > count) and it may be a

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

aaron.ballman added a comment. In D114235#3173549 , @mboehme wrote: > Aaron, have you had any chance to look at this yet? > > I added you as a reviewer because you expressed interest in something like > this in this discussion: >

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme added a comment. Aaron, have you had any chance to look at this yet? I added you as a reviewer because you expressed interest in something like this in this discussion: https://lists.llvm.org/pipermail/cfe-dev/2021-October/069097.html Is there someone else who would be more

[PATCH] D114235: [clang] Extend ParsedAttr to allow custom handling for type attributes

mboehme created this revision. mboehme added a reviewer: aaron.ballman. mboehme added a project: clang. mboehme requested review of this revision. Herald added a subscriber: cfe-commits. A typical use case would be to allow custom attributes for pointer types. See