[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

This revision was automatically updated to reflect the committed changes. Closed by commit rGf25935a00091: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs (authored by fwolff). Changed prior to commit: https://reviews.llvm.org/D114292?vs=400634&id=423908#toc Repository: r

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

aaron.ballman accepted this revision. aaron.ballman added a comment. Oh, yeah, this fell off my radar. Agreed, LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/new/ https://reviews.llvm.org/D114292 ___ cfe-commits mailing list cfe-c

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

whisperity accepted this revision. whisperity added a comment. This revision is now accepted and ready to land. Herald added a project: All. @aaron.ballman Alright, I think this can go. The `ReleaseNotes.rst` needs a rebase anyway. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/ne

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

fwolff updated this revision to Diff 400634. fwolff added a comment. I've added the `static_cast` and an entry in the release notes. I'm not sure how to handle `[[no_unique_address]]`, so I'd rather leave this to future work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114292/new/ ht

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

aaron.ballman added a comment. +1 to the request for a release note, but otherwise this LGTM (with or without the `static_cast` changes) in general. Should we also do something special for `[[no_unique_address]]` (if we should, I'm fine doing that in a follow-up)? Repository: rG LLVM Github

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

whisperity requested changes to this revision. whisperity added a comment. This revision now requires changes to proceed. I believe this is worth a note in the `ReleaseNotes.rst` file. People who might have disabled the check specifically for the reason outlined in the PR would get to know it's

[PATCH] D114292: [clang-tidy] Fix `altera-struct-pack-align` check for empty structs

fwolff created this revision. fwolff added reviewers: alexfh, whisperity, hokein. fwolff added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, rnkovacs, xazax.hun. fwolff requested review of this revision. Herald added a subscriber: cfe-commits. Fixes PR#51620