[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining abandoned this revision. SixWeining added a comment. Abandon because https://reviews.llvm.org/D115580 has already fixed it although later than my fix. Thanks @dexonsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

dexonsmith added a comment. Lost track of this again :/. Was just about to commit this for you (finally) but it looks like https://reviews.llvm.org/D115580 has already fixed it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https://reviews.llvm.org/D114505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining added a comment. In D114505#3181637 , @dexonsmith wrote: > LGTM. Sorry for missing this before. Looks to me like the debian build > failure above is unrelated. > > If you need someone to commit for you, please include the info for > GIT_AUTH

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Sorry for missing this before. Looks to me like the debian build failure above is unrelated. If you need someone to commit for you, please include the info for GIT_AUTHOR_NAME a

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389696. SixWeining added a comment. diff1 and diff2 are the same, but diff1 build pass while diff2 build fail. So weird. Just reupload the patch to have a try. Sorry for the noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114505/new/ https:

[PATCH] D114505: [clang][unittests] Fix a clang unittest linking issue

SixWeining updated this revision to Diff 389650. SixWeining retitled this revision from "[clang][unittests]Fix a clang unittest linking issue" to "[clang][unittests] Fix a clang unittest linking issue". SixWeining edited the summary of this revision. SixWeining added a comment. Herald add

[PATCH] D114505: [clang][unittests]Fix a clang unittest linking issue

SixWeining created this revision. SixWeining added reviewers: cfe-commits, dexonsmith. Herald added a subscriber: mgorny. SixWeining requested review of this revision. Herald added a project: clang. Currently the clang/unittests/Basic/CMakeLists.txt links LLVMTestingSupport in an incorrect way th