[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

tra added a comment. In D114601#3224469 , @mojca wrote: > In D114601#3223155 , @tra wrote: > >> Ping. @mojca, do you need help landing the patch? > > Yes, please. I don't have commit access yet. > You can attribut

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. Also, I would like to get to do some further "baby steps" towards better support of CUDA on Windows in particular, but I would need some guidelines. I requested a special channel that would allow a bit of discussion https://discord.com/channels/636084430946959380/. What wo

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. In D114601#3223155 , @tra wrote: > Ping. @mojca, do you need help landing the patch? Yes, please. I don't have commit access yet. You can attribute it to mojca at macports.org, for example. We also need a fix for unit tests on the

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

tra added a comment. Ping. @mojca, do you need help landing the patch? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

tra added a comment. In D114601#3172199 , @mojca wrote: > What can/should I do next in order to proceed with this? Next step would be to commit the patch. If you do not have commit access, I can help you with that. If that's the case, please let me know

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added a comment. What can/should I do next in order to proceed with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:137 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( mojca wrote: > tra wrote: > > Do we want to keep this as the fall-back

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:137 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( tra wrote: > Do we want to keep this as the fall-back for cases when

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

tra added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:137 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( Do we want to keep this as the fall-back for cases when `CUDA_PATH` is

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389811. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca updated this revision to Diff 389808. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114601/new/ https://reviews.llvm.org/D114601 Files: clang/lib/Driver/ToolChains/Cuda.cpp Index: clang/lib/Driver/ToolChains/Cuda.cpp =

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca added inline comments. Comment at: clang/lib/Driver/ToolChains/Cuda.cpp:138 } else if (HostTriple.isOSWindows()) { -for (const char *Ver : Versions) - Candidates.emplace_back( - D.SysRoot + "/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v" + -

[PATCH] D114601: Read path to CUDA from env. variable CUDA_PATH on Windows

mojca created this revision. mojca added reviewers: tra, carlosgalvezp, Hahnfeld. mojca added a project: clang. Herald added a subscriber: yaxunl. mojca requested review of this revision. Herald added a subscriber: cfe-commits. This is heavily related to https://reviews.llvm.org/D114326 and uses a