iains updated this revision to Diff 409187.
iains added a comment.
address review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114714/new/
https://reviews.llvm.org/D114714
Files:
clang/include/clang/Basic/Module.h
urnathan added inline comments.
Comment at: clang/include/clang/Basic/Module.h:109
-/// This is a C++ Modules TS module interface unit.
+/// This is a C++ Modules TS or C++20 module interface unit.
ModuleInterfaceUnit,
iains wrote:
> urnathan
iains added inline comments.
Comment at: clang/include/clang/Basic/Module.h:109
-/// This is a C++ Modules TS module interface unit.
+/// This is a C++ Modules TS or C++20 module interface unit.
ModuleInterfaceUnit,
urnathan wrote:
> I think it's
urnathan added inline comments.
Comment at: clang/include/clang/Basic/Module.h:109
-/// This is a C++ Modules TS module interface unit.
+/// This is a C++ Modules TS or C++20 module interface unit.
ModuleInterfaceUnit,
I think it's confusing to
iains created this revision.
Herald added a subscriber: dexonsmith.
iains updated this revision to Diff 404447.
iains added a comment.
iains retitled this revision from "[modules] Add enumerations for partition
modules and stream them." to "[C++20][Modules] Add enumerations for partition
modules