[PATCH] D114812: [HIP] Add pre-defined macro `__HIPCC_RDC__`

2021-11-30 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D114812#3162282 , @yaxunl wrote: > I am not sure whether we want to define a similar macro for cuda-clang. > > Maybe `__CLANG_RDC__` is better? I think it would make sense. For CUDA compatibility we can the define __CUDACC_RDC__

[PATCH] D114812: [HIP] Add pre-defined macro `__HIPCC_RDC__`

2021-11-30 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl added a comment. I am not sure whether we want to define a similar macro for cuda-clang. Maybe `__CLANG_RDC__` is better? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114812/new/ https://reviews.llvm.org/D114812 ___ cfe-commits

[PATCH] D114812: [HIP] Add pre-defined macro `__HIPCC_RDC__`

2021-11-30 Thread Yaxun Liu via Phabricator via cfe-commits
yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. nvcc defines `__CUDACC_RDC__` for both host and device compilation when -rdc=true is specified (https://docs.nvidia.com/cuda/cuda-compiler-driver-nvcc/index.html#nvcc-identification-macro) This