[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

2022-01-04 Thread Philip Reames via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0b09313cd533: [funcattrs] Infer writeonly argument attribute [part 2] (authored by reames). Changed prior to commit:

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

2022-01-04 Thread Philip Reames via Phabricator via cfe-commits
reames added inline comments. Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:728 + } else if (CB.hasFnAttr(Attribute::WriteOnly) || + CB.dataOperandHasImpliedAttr(UseIndex, Attribute::WriteOnly)) { +IsWrite = true; nikic

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

2022-01-04 Thread Nikita Popov via Phabricator via cfe-commits
nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/Transforms/IPO/FunctionAttrs.cpp:728 + } else if (CB.hasFnAttr(Attribute::WriteOnly) || + CB.dataOperandHasImpliedAttr(UseIndex,

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

2022-01-03 Thread Philip Reames via Phabricator via cfe-commits
reames updated this revision to Diff 397124. reames edited the summary of this revision. reames added a comment. Rework account for only being to infer on nocapture arguments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115003/new/ https://reviews.llvm.org/D115003 Files:

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

2021-12-03 Thread Philip Reames via Phabricator via cfe-commits
reames planned changes to this revision. reames added a comment. Has the same propagation bug fixed in 7b54de5f , need to rework. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115003: [funcattrs] Infer writeonly argument attribute [part 2]

2021-12-02 Thread Philip Reames via Phabricator via cfe-commits
reames created this revision. reames added reviewers: jdoerfert, anna, aeubanks, modimo, sstefan1. Herald added subscribers: jeroen.dobbelaere, ormris, kerbowa, bollu, hiraditya, sbc100, nhaehnle, jvesely, mcrosier. reames requested review of this revision. Herald added subscribers: cfe-commits,