[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b172f60c692: [HIP] Fix -fgpu-rdc for Windows (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115039/new/

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

yaxunl added a comment. In D115039#3174154 , @tra wrote: >> Put __hip_gpubin_handle in comdat when it has linkonce_odr linkage. > > I wonder when would this happen? I'm not sure we ever want gpubin handles > from different TUs merged. I think it may

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

tra added a comment. > Put __hip_gpubin_handle in comdat when it has linkonce_odr linkage. I wonder when would this happen? I'm not sure we ever want gpubin handles from different TUs merged. I think it may result in different TUs attempting to load/init the same GPU binary multiple times.

[PATCH] D115039: [HIP] Fix -fgpu-rdc for Windows

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. This patch fixes issues for -fgpu-rdc for Windows MSVC toolchain: Fix COFF specific section flags and remove section types in llvm-mc input file for Windows. Escape fatbin path in llvm-mc input