[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e08a1208889: [clang] Fall back on Android triple w/o API level for runtimes search (authored by collinbaker, committed by thakis). Changed prior

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

thakis accepted this revision. thakis added a comment. lg! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 ___ cfe-commits mailing list

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 397394. collinbaker added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files: clang/include/clang/Driver/ToolChain.h

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker marked 2 inline comments as done. collinbaker added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:500 + if (getTriple().isAndroid() && + getTriple().getEnvironmentName() != "android") { +llvm::outs() << getTriple().getEnvironmentName() <<

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 393978. collinbaker added a comment. - Address comments - Fix VEToolchain build error - Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files:

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. LGTM once the comments are addressed. (I'd also approve the alternative approach discussed in the thread of searching each older API level directory, but have no preference one way or

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

thakis added a comment. This looks right to me. Comment at: clang/lib/Driver/Driver.cpp:1846 +if (RuntimePaths.size() > 0 && getVFS().exists(RuntimePaths[0])) + llvm::outs() << RuntimePaths[0] << '\n'; else This either needs to print all of them,

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

thakis added a comment. Looks like this breaks tests on Windows: https://buildkite.com/llvm-project/premerge-checks/builds/68330#746376c2-ce48-4ffc-b60f-515619dee28c Failed Tests (2): Clang :: Driver/ve-toolchain.c Clang :: Driver/ve-toolchain.cpp Repository: rG LLVM Github

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker updated this revision to Diff 391661. collinbaker added a comment. Fix variable name style Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115049/new/ https://reviews.llvm.org/D115049 Files: clang/include/clang/Driver/ToolChain.h

[PATCH] D115049: Fall back on Android triple w/o API level for runtimes search

collinbaker created this revision. Herald added subscribers: abrachet, danielkiss, kristof.beyls. collinbaker requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Clang searches for runtimes (e.g. libclang_rt*) first in a subdirectory named for