[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG2a73a1ac57f0: [clang-format] PR48916 PointerAlignment not working when using C++20 init… (authored by MyDeveloperDay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius accepted this revision. curdeius added a comment. This revision is now accepted and ready to land. LGTM! Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 ___ cfe-commits mailing list

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 393048. MyDeveloperDay added a comment. Add more unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files: clang/lib/Format/FormatToken.cpp clang/lib/Format/FormatToken.h

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); HazardyKnusperkeks wrote: > curdeius wrote: > >

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > curdeius wrote: > > How

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 392703. MyDeveloperDay added a comment. Add some more unit tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files: clang/lib/Format/FormatToken.cpp clang/lib/Format/FormatToken.h

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius requested changes to this revision. curdeius added a comment. This revision now requires changes to proceed. Requesting changes so that appears correctly in the review queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:1947 verifyFormat("int&& c = f3();", Style); + verifyFormat("for (auto a = 0, b = 0; const auto& c : {1, 2, 3})", Style); curdeius wrote: > How about pointers/references in

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay added a comment. In D115050#3172842 , @HazardyKnusperkeks wrote: > You have reverted some of your changes. Including all the tests. Yes oops! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 391993. MyDeveloperDay marked an inline comment as done. MyDeveloperDay added a comment. Fix the merge and add the tests back (which missed the patch) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added a comment. You have reverted some of your changes. Including all the tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 ___ cfe-commits mailing list

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 391990. MyDeveloperDay added a comment. This fix has to go super specific to range for loops or we start manipulating pointer alignment all over the place in places perhaps we don't want to CHANGES SINCE LAST ACTION

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay updated this revision to Diff 391915. MyDeveloperDay marked 2 inline comments as done. MyDeveloperDay added a comment. Address review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115050/new/ https://reviews.llvm.org/D115050 Files:

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

curdeius added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3054 + return true; +// & // comment +if (Right.is(TT_BlockComment)) Block, not line, comment Comment at: clang/unittests/Format/FormatTest.cpp:1947

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Is this valid code? Or did we just wrongly assign

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; HazardyKnusperkeks wrote: > Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3052 +// & 1 +if (Right.Tok.isLiteral()) + return true; Is this valid code? Or did we just wrongly assign PointerOrReference? I'd say after that there can not

[PATCH] D115050: [clang-format] PR48916 PointerAlignment not working when using C++20 init-statement in for loop

MyDeveloperDay created this revision. MyDeveloperDay added reviewers: HazardyKnusperkeks, curdeius. MyDeveloperDay added projects: clang, clang-format. MyDeveloperDay requested review of this revision. https://bugs.llvm.org/show_bug.cgi?id=48916 Left and Right Alignment inside a loop is