[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

This revision was automatically updated to reflect the committed changes. Closed by commit rGbfe07195bb1f: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT (authored by stuij). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 393096. stuij added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

danielkiss accepted this revision. danielkiss added a comment. This revision is now accepted and ready to land. In D115140#3176800 , @stuij wrote: > @danielkiss Yes that needs to be addressed, but we are doing that in another > patch that will

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij added a comment. @danielkiss Yes that needs to be addressed, but we are doing that in another patch that will (hopefully) cover all permutations of architecture and branch protection values on both the cmdline and as function attributes. So this patch is just about not having logic in

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

danielkiss added a comment. I think rejecting\warning the `b-key` from the command line maybe a more developer friendly way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 392021. stuij added a comment. another tickle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files: clang/lib/Basic/Targets/ARM.cpp

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij updated this revision to Diff 392013. stuij added a comment. tickling the commit so the buildbot picks up the dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115140/new/ https://reviews.llvm.org/D115140 Files:

[PATCH] D115140: [ARM][clang] Option b-key must not affect __ARM_FEATURE_PAC_DEFAULT

stuij created this revision. Herald added a subscriber: kristof.beyls. stuij requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When using -mbranch-protection=pac-ret+b-key, macro __ARM_FEATURE_PAC_DEFAULT should still have the value