[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D115232: [clangd] Indexing of standard library

bnbarham added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:1008-1010 + // TUScheduler is the only thing that starts background indexing work. + if (IndexTasks && !IndexTasks->wait(timeoutSeconds(TimeoutSeconds))) +return false;

[PATCH] D115232: [clangd] Indexing of standard library

sammccall closed this revision. sammccall added a comment. Landed finally as 03ea140b3a285c9a4400ee007b1790b110cbf984 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. I managed to get a stack trace from a bot (by leaving the broken commit up for longer this time). In D115232#3522598 , @thakis wrote: > In D115232#3522571

[PATCH] D115232: [clangd] Indexing of standard library

thakis added a comment. In D115232#3522571 , @sammccall wrote: > In D115232#3522514 , @thakis wrote: > >> In D115232#3520461 , @sammccall >> wrote: >> >>> Hmm, the test

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. In D115232#3522514 , @thakis wrote: > In D115232#3520461 , @sammccall > wrote: > >> Hmm, the test keeps crashing on the GN bot: >> http://45.33.8.238/win/58316/step_9.txt >>

[PATCH] D115232: [clangd] Indexing of standard library

thakis added a comment. In D115232#3520461 , @sammccall wrote: > Hmm, the test keeps crashing on the GN bot: > http://45.33.8.238/win/58316/step_9.txt > Unfortunately the stacktrace is not symbolized, and I'm not seeing this > elsewhere (e.g. premerge

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a subscriber: thakis. sammccall added a comment. Hmm, the test keeps crashing on the GN bot: http://45.33.8.238/win/58316/step_9.txt Unfortunately the stacktrace is not symbolized, and I'm not seeing this elsewhere (e.g. premerge bot). @thakis, any idea why unittests no longer

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 430130. sammccall added a comment. fix HasSubstr matcher type issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files:

[PATCH] D115232: [clangd] Indexing of standard library

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecaa4d9662c9: [clangd] Indexing of standard library (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 430062. sammccall added a comment. Address comments Add end-to-end test Move ownership of AsyncTaskRunner to allow blockUntilIdle() in test Fix bugs caught by end-to-end-test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115232: [clangd] Indexing of standard library

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. sorry for the long turn around here, LGTM. let's ship it! Comment at: clang-tools-extra/clangd/index/StdLib.cpp:233 + // Sadly we can't use IndexOpts.FileFilter to

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. This had a "LG" comment above... want to take another pass? (Not urgent, just checking) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/index/StdLib.cpp:313 +llvm::StringRef DirPath = llvm::sys::path::parent_path(HeaderPath); +if (!HS.getFileMgr().getVirtualFileSystem().getRealPath(DirPath, Path)) + SearchPaths.emplace_back(Path);

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 419265. sammccall added a comment. revert to previous version of realpath code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files:

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 419262. sammccall added a comment. Revert StdLibLocation to realpath, document why Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/ https://reviews.llvm.org/D115232 Files:

[PATCH] D115232: [clangd] Indexing of standard library

sammccall added a comment. (sorry about the long delay, would still love to merge this) Comment at: clang-tools-extra/clangd/index/StdLib.cpp:92 + // The umbrella header is the same for all versions of each language. + // Headers that are unsupported in old lang versions are

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 419259. sammccall marked 15 inline comments as done. sammccall added a comment. Herald added a project: All. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115232/new/

[PATCH] D115232: [clangd] Indexing of standard library

kadircet added a comment. thanks LG, mostly nits and a couple of questions Comment at: clang-tools-extra/clangd/ClangdServer.cpp:91 +if (Tasks) + Tasks->runAsync("IndexStdlib", std::move(Task)); +else I suppose this should be rare hence won't bite

[PATCH] D115232: [clangd] Indexing of standard library

sammccall updated this revision to Diff 392605. sammccall retitled this revision from "[clangd] WIP various stdlib indexing stuff" to "[clangd] Indexing of standard library". sammccall edited the summary of this revision. sammccall added a subscriber: kuhnel. sammccall added a comment. Herald