[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c9119ab364b: [clangd] Extend SymbolOrigin, stop serializing it (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D115243?vs=394538=399555#toc Repository: rG LLVM Github

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall added a comment. (Our plan is to land this after new year some time, so that remote index servers don't get disrupted by format changes while people are on holiday) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall updated this revision to Diff 394538. sammccall added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://reviews.llvm.org/D115243 Files: clang-tools-extra/clangd/index/BackgroundIndexStorage.cpp

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall added a comment. In D115243#3185393 , @kadircet wrote: > Yes and no. As mentioned SymbolSlabs are frozen once created and I totally > agree with the reasons there. But AFAICT in none of the indexes (apart from > monolithic FileIndex) we ever

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. Thanks, LGTM! --- > The problem is these methods yield SymbolSlabs, and the symbols within them > are frozen/const. There's no provision to "just tweak some bitfield" - we'd > have to

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall added a comment. > I think we also need to update index/remote/Server.cpp && FileSymbols (and > FileIndex too). Done. I wonder why premerge tests didn't fail for FileIndex not being updated? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall updated this revision to Diff 392612. sammccall added a comment. Update remote index server and FileIndex Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://reviews.llvm.org/D115243 Files:

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall updated this revision to Diff 392609. sammccall marked an inline comment as done. sammccall added a comment. fix sigils Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115243/new/ https://reviews.llvm.org/D115243 Files:

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall marked 2 inline comments as done. sammccall added a comment. In D115243#3176741 , @kadircet wrote: > I think we also need to update `index/remote/Server.cpp` && `FileSymbols` > (and `FileIndex` too). > > Regarding updates to `loadIndex`, I

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

kadircet added a comment. I think we also need to update `index/remote/Server.cpp` && `FileSymbols` (and `FileIndex` too). Regarding updates to `loadIndex`, I actually think it makes sense for that index the always retrieve symbols as `Static` origin, then whoever makes use of that (we always

[PATCH] D115243: [clangd] Extend SymbolOrigin, stop serializing it

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added subscribers: wenlei, usaxena95, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. New values: - Split