This revision was automatically updated to reflect the committed changes.
Closed by commit rG2ccf0b76bcaf: Fix build failure with GCC 11 in C++20 mode
(authored by Godin, committed by martong).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Godin added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115355/new/
https://reviews.llvm.org/D115355
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Godin added a comment.
Can someone please commit this on my behalf since I do not have commit rights?
Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403
+ AttrArgImporter(const AttrArgImporter &) = delete;
+ AttrArgImporter(AttrArgImporter &&) = default;
AttrArgImporter
dexonsmith accepted this revision.
dexonsmith added a comment.
LGTM too.
Comment at: clang/lib/AST/ASTImporter.cpp:8400-8403
+ AttrArgImporter(const AttrArgImporter &) = delete;
+ AttrArgImporter(AttrArgImporter &&) = default;
AttrArgImporter =(const AttrArgImporter &) =
Godin added a comment.
Thank you for the review @shafik !
As a note: this change is similar to the
https://reviews.llvm.org/rG95d0d8e9e9d10da3cfa503fbba405e740aea3cc1 by @rsmith
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115355/new/
shafik added a comment.
LGTM but I want to give a chance for others to chime in.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115355/new/
https://reviews.llvm.org/D115355
___
cfe-commits mailing list
Godin created this revision.
Herald added subscribers: dexonsmith, martong, hiraditya, MatzeB.
Herald added a reviewer: shafik.
Godin requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
See https://wg21.link/cwg2237
