[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG18f087c21cdb: [DebugInfo][Clang] record the access flag for class/struct/union types. (authored by Esme). Repository: rG LLVM Github Monorepo

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added a comment. In D115503#3199489 , @shchenz wrote: > In D115503#3199459 , @Esme wrote: > >> In D115503#3195171 , @dblaikie >> wrote: >> >>> Ah, cool - could

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added a comment. In D115503#3199459 , @Esme wrote: > In D115503#3195171 , @dblaikie > wrote: > >> Ah, cool - could you include % growth on those rows > > Thanks, I edited the table in the previous

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3195171 , @dblaikie wrote: > Ah, cool - could you include % growth on those rows Thanks, I edited the table in the previous comment. > (hmm, .debug_line and .debug_str shouldn't be changing in size with this > change,

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added a comment. In D115503#3193978 , @Esme wrote: > In D115503#3192840 , @dblaikie > wrote: > >> Thanks for the data - looks good to me. Maybe include some of that data >> (summary of total binary

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3192840 , @dblaikie wrote: > Thanks for the data - looks good to me. Maybe include some of that data > (summary of total binary size change/total debug info size change - and if > you could include the flags (was this

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added a comment. In D115503#3191156 , @Esme wrote: > In D115503#3188302 , @dblaikie > wrote: > >> Got any data on how much this (combined with the LLVM patch) increases debug >> info size of, say, a

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added a comment. In D115503#3188302 , @dblaikie wrote: > Got any data on how much this (combined with the LLVM patch) increases debug > info size of, say, a clang self-host build? I assume not much, but wouldn't > hurt to know. Before: $ size

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie accepted this revision. dblaikie added a comment. Got any data on how much this (combined with the LLVM patch) increases debug info size of, say, a clang self-host build? I assume not much, but wouldn't hurt to know. (does GCC produce this sort of debug info, or does it skip the

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. Thanks for fixing this. LGTM. Please wait for @dblaikie comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: Esme wrote: > dblaikie wrote: > > shchenz wrote: > > > Will we generate a redundant flag if we define a private type in the > > > class or a public

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: dblaikie wrote: > shchenz wrote: > > Will we generate a redundant flag if we define a private type in the class > > or a public type in the

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme updated this revision to Diff 393805. Esme added a comment. Add a case to show that the default access flag is not recorded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115503/new/ https://reviews.llvm.org/D115503 Files:

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

dblaikie added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: shchenz wrote: > Will we generate a redundant flag if we define a private type in the class or > a public type in the struct/union? Maybe we could

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

shchenz added inline comments. Comment at: clang/test/CodeGenCXX/debug-info-access.cpp:28 +class C { +public: Will we generate a redundant flag if we define a private type in the class or a public type in the struct/union? Maybe we could add a case for that

[PATCH] D115503: [DebugInfo][Clang] record the access flag for class/struct/union types.

Esme updated this revision to Diff 393789. Esme retitled this revision from "[DebugInfo] emit DW_AT_accessibility attribute for class/struct/union types." to "[DebugInfo][Clang] record the access flag for class/struct/union types.". Esme added a comment. Thanks! @dblaikie Separate into Clang