[PATCH] D115604: [Support] Expand `` as the base directory in response files.

sepavloff added a comment. The name of the patch could be more precise if you change `response files` to `configuration files`. Comment at: clang/docs/UsersManual.rst:926-927 + +A potential `` use-case may be search paths in a portable (i.e. not +installed) SDK directory for

[PATCH] D115604: [Support] Expand `` as the base directory in response files.

jackoalan updated this revision to Diff 396410. jackoalan added a comment. Rebase, use the slightly more intuitive `` token to expand base paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 396055. jackoalan added a comment. Make expansion token a parameter of `ExpandResponseFiles` and limit use to `readConfigFile`. Elaborate manual entry further and add entry to release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. > 1. It it possible to limit the new syntax to config files only? It would > avoid concerns of gcc compatibility. Yes, ultimately this use case only calls for extending config files. > Is it possible to use more understandable designation, like `` or > something

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

sepavloff added a comment. Thank you for the detailed explanation. Now I see how you are going to use this facility and think it worth implementation. A couple of questions. 1. It it possible to limit the new syntax to config files only? It would avoid concerns of gcc compatibility. 2. The

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the sepavloff wrote: > Response

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

sepavloff added inline comments. Comment at: clang/docs/UsersManual.rst:920 +To generate paths relative to the configuration file, the `<@>` token may be +used. This will expand to the absolute path of the directory containing the Response and configuration

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. bump, review requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan added a comment. In D115604#3188392 , @kadircet wrote: > IIUC, the new behavior being introduced by this patch is not the ability of > having a way to refer to other files in a config/response file relative way, > but rather extending that

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

kadircet added a comment. IIUC, the new behavior being introduced by this patch is not the ability of having a way to refer to other files in a config/response file relative way, but rather extending that ability from only the options that start with `@` to options that contain `@` as a

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393785. jackoalan added a comment. Test coverage for more than one `<@>` per arg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files:

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393781. jackoalan added a comment. Fix ResponseFiles test for Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115604/new/ https://reviews.llvm.org/D115604 Files: clang/docs/UsersManual.rst

[PATCH] D115604: [Support] Expand `<@>` as the base directory in response files.

jackoalan updated this revision to Diff 393777. jackoalan added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add entry to user manual explaining the `<@>` token. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION