[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

nikic added inline comments. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; cameron.mcinally wrote: > nikic wrote: > >

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

cameron.mcinally added inline comments. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; nikic wrote: > cameron.mcinally wrote: > >

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

nikic added inline comments. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; cameron.mcinally wrote: > Sorry for the late comment,

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

cameron.mcinally added inline comments. Herald added a project: All. Comment at: llvm/lib/Analysis/ConstantFolding.cpp:722 + (Ty->isIntOrIntVectorTy() || Ty->isFPOrFPVectorTy())) +return Constant::getAllOnesValue(Ty); + return nullptr; Sorry for the

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

nikic added a comment. In the meantime, I've applied https://github.com/llvm/llvm-project/commit/2926d6d335aca7e3f57ac45e6b25b1716e053fb3 as a targeted fix for the original assertion failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

nikic added a comment. @paulwalker-arm Thanks for the report, I've reverted the commit for now. I've put up D115994 to either fix the test or be told that clang generates incorrect initialization code, I'm not completely sure which it is. Repository: rG

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

paulwalker-arm added a comment. This patch looks to be breaking the clang-aarch64-sve-vla-2stage buildbot (and probably also clang-aarch64-sve-vls-2stage). I've checked this using `./bin/clang -DNDEBUG -O3 -w -Werror=date-time -w pr19687.c && ./a.out && echo "success"`, which works before this

[PATCH] D115924: [ConstantFolding] Unify handling of load from uniform value

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fd4f80e33a4: [ConstantFolding] Unify handling of load from