This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb5c5d8912e07: [clang][dataflow] Add support for noreturn
destructor calls (authored by sgatev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
sgatev marked an inline comment as done.
sgatev added a comment.
Thanks for the reviews!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116022/new/
https://reviews.llvm.org/D116022
___
cfe-commits mailing
sgatev marked an inline comment as done.
sgatev added inline comments.
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:196
+
+class VirtualDestructorTest : public ::testing::Test {
+protected:
gribozavr2 wrote:
> DYM "Noretu
sgatev updated this revision to Diff 395979.
sgatev marked an inline comment as done.
sgatev added a comment.
Rename a test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116022/new/
https://reviews.llvm.org/D116022
Files:
clang/include/clang/An
gribozavr2 added inline comments.
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:196
+
+class VirtualDestructorTest : public ::testing::Test {
+protected:
DYM "Noreturn" instead of "Virtual"?
Repository:
rG LLVM Github
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116022/new/
https://reviews.llvm.org/D116022
__
