[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG83028ad934d6: [clang][AST][ASTImporter] Set record to complete during import of its members. (authored by balazske). Repo

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske updated this revision to Diff 407860. balazske added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTes

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske updated this revision to Diff 407822. balazske added a comment. Fix of test failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

steakhal added a comment. Well, I've just recognized that the "Build Status" of this latest diff shows that it crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 ___

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

steakhal added a comment. In D116155#3303622 , @balazske wrote: > @martong Ping > We do not have possibility currently to check all LLDB tests. I think we can > commit this and observe the buildbots for failure. I agree. Let's see if it works out. I don

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added a comment. (The current code does not work, the mentioned fixes must be applied first.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 ___ cfe-c

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added a comment. @martong Ping We do not have possibility currently to check all LLDB tests. I think we can commit this and observe the buildbots for failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

teemperor added a comment. I'm really sorry @martong , but I no longer work on LLDB (or the ASTImporter) and I'm not really in the loop regarding LLDB development. (Having said that, I still happy to answer questions about my own patches/reviews that I did in the past in case there are question

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

martong added a subscriber: teemperor. martong added a comment. Adding Raphael @teemperor , he might have useful comments about the minimal mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews.llvm.org/D116155 _

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added a comment. Ping. I want to see opinion of @shafik (or others) about change of test `CompleteRecordBeforeImporting` (turn on minimal import mode in this test). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116155/new/ https://reviews

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

martong added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. balazske wrote: > ba

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. balazske wrote: > s

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. shafik wrote: > So

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

shafik added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:2021 + // fields imported) at that time without multiple AST import passes. + To->setCompleteDefinition(true); // Complete the definition even if error is returned. So `DefinitionComplet

[PATCH] D116155: [clang][AST][ASTImporter] Set record to complete during import of its members.

balazske created this revision. Herald added subscribers: steakhal, martong, gamesh411, Szelethus, dkrupp. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. balazske requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At impo