[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

2022-02-07 Thread Son Tuan Vu via Phabricator via cfe-commits
tyb0807 abandoned this revision. tyb0807 added a comment. This is superseded by https://reviews.llvm.org/D118199. Comments have been addressed in the new patch. I should have commandeered this patch instead (did not know about this, sorry...). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

2021-12-22 Thread Momchil Velikov via Phabricator via cfe-commits
chill added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:666 + HasMOPS |= ArchKind == llvm::AArch64::ArchKind::ARMV8_8A || + ArchKind == llvm::AArch64::ArchKind::ARMV9_3A; So, this is enabled by default (as in "is mandatory part

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

2021-12-22 Thread Kyrill Tkachov via Phabricator via cfe-commits
ktkachov added a comment. I think the most important use of the __ARM_FEATURE_MOPS is to check whether it's safe to use the new intrinsics, so it should only be defined by the compiler once it supports the intrinsics proposed in https://github.com/ARM-software/acle/pull/38/files Repository:

[PATCH] D116160: [AArch64] ACLE feature macro for Armv8.8-A MOPS

2021-12-22 Thread Tomas Matheson via Phabricator via cfe-commits
tmatheson created this revision. Herald added a subscriber: kristof.beyls. tmatheson requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This introduces the new `__ARM_FEATURE_MOPS` ACLE feature test macro, which signals the a