[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 396490. junaire added a comment. Extend emitUnaryBuiltin instead of adding a new overload, also apply it to __builtin_elementwise_abs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3211178 , @junaire wrote: > In order to use `emitUnaryBuiltin` in other cases, I changed the function > interface. > This allows us to use it in all `Builder.CreateUnaryIntrinsic()` cases, but > will make > the

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 396380. junaire added a comment. In order to use `emitUnaryBuiltin` in other cases, I changed the function interface. This allows us to use it in all `Builder.CreateUnaryIntrinsic()` cases, but will make the function body very small. Repository: rG LLVM

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. In D116161#3209292 , @fhahn wrote: > In D116161#3209286 , @junaire wrote: > >> 35: %0 = load float, float* %f1.addr, align 4 >> 36: %1 = load float, float* %f1.addr, align 4 >>

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3209286 , @junaire wrote: > 35: %0 = load float, float* %f1.addr, align 4 > 36: %1 = load float, float* %f1.addr, align 4 > 37: %elt.abs = call float @llvm.fabs.f32(float %1) It looks like the argument

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. I confirmed that we can use `emitUnaryBuiltin` in the cases you pointed out. Please see the logs below: $ path/to/llvm-project/build/bin/clang -cc1 -internal-isystem /path/to/llvm-project/build/lib/clang/14.0.0/include -nostdsysteminc -triple x86_64-apple-darwin

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. I don't know why but these will cause tests to fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits mailing list

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3137 else Result = Builder.CreateUnaryIntrinsic(llvm::Intrinsic::fabs, Op0, nullptr, "elt.abs"); Should also be used here?

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 396140. junaire added a comment. Fix wrong usage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files: clang/lib/CodeGen/CGBuiltin.cpp Index:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395864. junaire added a comment. Update the existing place that can use emitUnaryBuiltin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395863. junaire added a comment. Update the existing place that can use emitUnaryBuiltin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire added a comment. In D116161#3206447 , @fhahn wrote: > In D116161#3206442 , @junaire wrote: > >> Update the existing place that can use `emitUnaryBuiltin`. > > I meant just update the existing uses

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. In D116161#3206442 , @junaire wrote: > Update the existing place that can use `emitUnaryBuiltin`. I meant just update the existing uses *without* adding `floor`, `roundeven`, `trunc`, so this change should be NFC (non-functional

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395853. junaire added a comment. Sorry, It seems that the base branch is wrong, reupdate it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire updated this revision to Diff 395852. junaire added a comment. Update the existing place that can use `emitUnaryBuiltin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 Files:

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

fhahn added a comment. Can you also update the existing places that could use it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits mailing list

[PATCH] D116161: [Clang] Add an overload for emitUnaryBuiltin.

junaire created this revision. junaire added reviewers: fhahn, arsenm. junaire requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. This patch adds an overload for emitUnaryBuiltin, which is addressed in D115429