[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea64d5585ec: [clang-format] Fix short enums getting wrapped even when denied (authored by yodaldevoid, committed by owenpan). Repository: rG

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid added a comment. In D116188#3208456 , @HazardyKnusperkeks wrote: > Since you only upload a diff, there is no name or email. ;) It had looked like arcanist was retaining this information, but I now realize what it was doing. At any rate, I

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 ___ cfe-commits mailing list

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D116188#3208378 , @yodaldevoid wrote: > Correct commit email Since you only upload a diff, there is no name or email. ;)

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid updated this revision to Diff 396060. yodaldevoid added a comment. Correct commit email Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 Files: clang/lib/Format/UnwrappedLineFormatter.cpp

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid updated this revision to Diff 396041. yodaldevoid added a comment. Addressed reviewer comments - Removed unnecessary null checks - Added tests for typedefs preceding short enums Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:398-400 + if (Tok && Tok->is(tok::kw_typedef)) +Tok = Tok->getNextNonComment(); + if (Tok && Tok->isOneOf(tok::kw_class, tok::kw_struct)) { Nits: - It's

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

MyDeveloperDay added a comment. Can you test the typedef case you added? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116188/new/ https://reviews.llvm.org/D116188 ___ cfe-commits mailing list

[PATCH] D116188: [clang-format] Fix short enums getting wrapped even when denied

yodaldevoid created this revision. yodaldevoid added reviewers: HazardyKnusperkeks, MyDeveloperDay, curdeius, owenpan. yodaldevoid requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Single-variant enums were still getting placed on a single