This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2edcde00cb39: [MIPS] Add -mfix4300 flag to enable vr4300
mulmul bugfix pass (authored by Random06457, committed by atanasyan).
Changed prior to comm
atanasyan accepted this revision.
atanasyan added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116238/new/
https://reviews.llvm.org/D116238
___
cfe-commi
Random06457 updated this revision to Diff 396171.
Random06457 added a comment.
Addressed the comments.
I also updated `isFirstMul` to exclude integer multiplications which do not
produce the bug. That change made me fix the tests too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116238
atanasyan requested changes to this revision.
atanasyan added a comment.
This revision now requires changes to proceed.
Thanks for the patch. Some notes are below.
Comment at: llvm/lib/Target/Mips/MipsMulMulBugPass.cpp:16
+static cl::opt
+EnableMulMulFix("mfix4300", cl::ini
Random06457 created this revision.
Random06457 added a reviewer: atanasyan.
Herald added subscribers: dang, jrtc27, hiraditya, arichardson, mgorny, sdardis.
Random06457 requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Early
