[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-28 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:14545 verifyFormat("auto lambda = []() { return 0; };", SomeSpace2); + + FormatStyle SpaceAfterOperatorOverloading = getLLVMStyle(); There should be a PARSE unit test too

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-27 Thread Rajat Bajpai via Phabricator via cfe-commits
rajatbajpai updated this revision to Diff 396314. rajatbajpai added a comment. Fixed the patch file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-27 Thread Rajat Bajpai via Phabricator via cfe-commits
rajatbajpai updated this revision to Diff 396302. rajatbajpai added a comment. Incorporated review comments. Changelog: 1. Using unit test case instead of lit test case. 2. Placed the option according to alphabetical order. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-27 Thread Björn Schäpers via Phabricator via cfe-commits
HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3383 +///true: false: +///void operator++ (int a); vs.void operator++(int +///a); Please put

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-26 Thread MyDeveloperDay via Phabricator via cfe-commits
MyDeveloperDay added a comment. you need to add a unit test int clang/unittest/Format/FormatTest.cpp (we tend to not use lit tests) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116283/new/ https://reviews.llvm.org/D116283

[PATCH] D116283: Added an option to add a space between operator overloading and opening parentheses in clang-format

2021-12-26 Thread Rajat Bajpai via Phabricator via cfe-commits
rajatbajpai created this revision. rajatbajpai added a reviewer: MyDeveloperDay. rajatbajpai added a project: clang-format. rajatbajpai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change adds an option AfterOperatorOverloading in