[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0944c196c58f: [libTooling] Adds more support for constructing object access expressions. (authored by ymandel). Repository: rG LLVM Github

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 402984. ymandel added a comment. Herald added a subscriber: JDevlieghere. fix bad previous snapshot Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files:

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 402910. ymandel added a comment. extended list of pointer-like types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files:

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCodeBuilders.cpp:78 + returns(qualType(references(type())); + const auto SmartPointer = qualType(hasDeclaration( + cxxRecordDecl(anyOf(KnownSmartPointer,

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 402663. ymandel marked 9 inline comments as done. ymandel added a comment. addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files:

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

gribozavr2 added inline comments. Comment at: clang/unittests/Tooling/SourceCodeBuildersTest.cpp:373 +TEST(SourceCodeBuildersTest, BuildAccessSmartPointer) { + testBuilder(buildAccess, "Smart x; x;", "x->"); +} ymandel wrote: > gribozavr2 wrote: > > This is a

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/unittests/Tooling/SourceCodeBuildersTest.cpp:373 +TEST(SourceCodeBuildersTest, BuildAccessSmartPointer) { + testBuilder(buildAccess, "Smart x; x;", "x->"); +} gribozavr2

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Tooling/Transformer/SourceCodeBuilders.cpp:78 + returns(qualType(references(type())); + const auto

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

asoffer added inline comments. Comment at: clang/lib/Tooling/Transformer/SourceCodeBuilders.cpp:73 + cxxRecordDecl(hasAnyName("::std::unique_ptr", "::std::shared_ptr")); + const auto QuacksLikeASmartPointer = cxxRecordDecl( +

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel updated this revision to Diff 397356. ymandel added a comment. ignore implicit and add deprecations Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116377/new/ https://reviews.llvm.org/D116377 Files:

[PATCH] D116377: [libTooling] Adds more support for constructing object access expressions.

ymandel created this revision. ymandel added a reviewer: gribozavr2. ymandel requested review of this revision. Herald added a project: clang. This patch adds a `buildAccess` function, which constructs a string with the proper operator to use based on the expression's form and type. It also adds